-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ramp time extended by 0.03s after capture gain curve_duration change #8238
Comments
The commit message says "This change increases the ramp duration from 20 ms to 50 ms" So it's not a bug, it's a feature? :-) |
Not sure about this, but alsabat cannot survive from such long ramp time. |
Ouch, but there's justification for this change. 1) capture artefacts mitigation accidentally dropped from tplg2 vs. tplg1 2) we can avoid a big MCPS peak with this lower rate ramp. Is there a way to ask alsabat to ignore a bit longer audio from beginning? |
If not possible to change alsabat we can have a test topology with short ramp? |
We need to care about audio user experience and peak MCPS usage in production topologies. The alsabat test is disturbed by longer ramp so it can be removed from nocodec topologies since the codec is never used by end users and also the peak MCPS mitigation is not relevant for a test topology, as long as higher MCPS is not triggering error reports. The curve duration becomes without explicit set the default 20 ms. Fixes: thesofproject#8238 Fixes: d0d74a4 ("Tools: Topology2: Change in capture gain curve_duration to 50 m") Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
I could not find from alsabat command line options to ignore audio from very beginning of test. I don't like at all to change something because of limitation in our test procedure but this might help #8242 . |
We need to care about audio user experience and peak MCPS usage in production topologies. The alsabat test is disturbed by the longer ramp so the change can be reverted from nocodec topologies. Those topologies are never used by end users. Also the peak MCPS mitigation is not relevant for test topologies, as long as higher MCPS is not triggering error reports. The curve duration is restored without explicit set to the default 20 ms. Fixes: thesofproject#8238 Fixes: d0d74a4 ("Tools: Topology2: Change in capture gain curve_duration to 50 m") Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu ack, the topology used for the test can have its ramp shortened, providing its not a end user topology. i.e. testing only topology. |
We need to care about audio user experience and peak MCPS usage in production topologies. The alsabat test is disturbed by the longer ramp so the change can be reverted from nocodec topologies. Those topologies are never used by end users. Also the peak MCPS mitigation is not relevant for test topologies, as long as higher MCPS is not triggering error reports. The curve duration is restored without explicit set to the default 20 ms. Fixes: #8238 Fixes: d0d74a4 ("Tools: Topology2: Change in capture gain curve_duration to 50 m") Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Let's wait for validation in the next daily test run. Stupid Github auto close anti-feature: https://github.com/orgs/community/discussions/17308 |
Confirmed that alsabat test passed after applying #8242 on nocodec platforms. Closing this bug. |
Describe the bug
Observed this issue on all IPC4-nocodec(single core) platforms. it caused alsabat test failures.
The ramp time extended by 0.03s after capture gain curve_duration change(d0d74a4):
To Reproduce
check the alsabat wav file
Reproduction Rate
100%
Environment
The text was updated successfully, but these errors were encountered: