Skip to content

Commit

Permalink
.github: build again single-threaded and verbose on failure
Browse files Browse the repository at this point in the history
Building in parallel is much faster but it makes logs unreadable and
build failures impossible to understand. This is especially true when
building with recent ALSA that produces of deprecation warnings.

To show what actually fails, try to build again with a single thread.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
  • Loading branch information
marc-hb authored and lgirdwood committed Apr 5, 2022
1 parent bde4858 commit 791efe2
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ jobs:
run: docker pull thesofproject/sof && docker tag thesofproject/sof sof

# -j3 tests the ability to build multiple platforms
# concurrently. It makes the build log unreadable but that's OK
# because we have other, slower actions with readable logs.
# concurrently. It makes the build log unreadable, so retry with
# a single thread in case of failure
- name: build all and stage
run: ./scripts/docker-run.sh make -j3 -C installer/ tarball
run: ./scripts/docker-run.sh make -j3 -C installer/ tarball ||
VERBOSE=1 NO_PROCESSORS=1 USE_XARGS=no
./scripts/docker-run.sh make -j1 -C installer/ tarball

- name: check staging tree
run: make -C installer/ checktree
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,10 @@ jobs:
# Use our docker container to avoid the "unsupported widget type asrc"
# bug in ALSA 1.2.2
# https://github.com/thesofproject/sof/issues/2543
- name: build topologies
run: ./scripts/docker-run.sh ./scripts/build-tools.sh -t
- name: build test topologies
run: ./scripts/docker-run.sh ./scripts/build-tools.sh -t ||
VERBOSE=1 NO_PROCESSORS=1 USE_XARGS=no
./scripts/docker-run.sh ./scripts/build-tools.sh -t

- name: build testbench
run: ./scripts/rebuild-testbench.sh
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,7 @@ jobs:
# For some reason gcc has more warnings in Release mode
- name: build-tools
run: CMAKE_BUILD_TYPE=Release ./scripts/docker-run.sh
./scripts/build-tools.sh ||
VERBOSE=1 NO_PROCESSORS=1 USE_XARGS=no
CMAKE_BUILD_TYPE=Release ./scripts/docker-run.sh
./scripts/build-tools.sh

0 comments on commit 791efe2

Please sign in to comment.