Skip to content

Commit

Permalink
actions: consolidate yamlint
Browse files Browse the repository at this point in the history
Lets not trust that everyone remembers to lint themselves or that they
fetch the repo in order to execute their job.

Also rename workflow file to be a bit more generic

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
  • Loading branch information
cujomalainey authored and lgirdwood committed May 18, 2021
1 parent e11c3c9 commit 0a1029c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# github.com also has a powerful web editor that can be used without
# committing.

name: checkpatch
name: codestyle

# yamllint disable-line rule:truthy
on: [pull_request]
Expand All @@ -31,9 +31,6 @@ jobs:
- uses: actions/checkout@v2
with: {fetch-depth: 2}

- name: yamllint ourselves
run: yamllint .github/workflows/shallow_checkpatch.yml

- name: install codespell
run: sudo apt-get -y install codespell && dpkg -L codespell | grep dict

Expand All @@ -51,3 +48,10 @@ jobs:
- name: checkpatch --strict
run: .github/workflows/checkpatch_list.sh ${CHK_CMD_OPTS}
--strict < PR_SHAs.txt
yamllint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- name: run yamllint
run: yamllint --strict .github/workflows/*.yml
3 changes: 0 additions & 3 deletions .github/workflows/installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ jobs:
# From time to time this will catch a git tag and change SOF_VERSION
with: {fetch-depth: 50, submodules: recursive}

- name: yamllint ourselves
run: yamllint .github/workflows/installer.yml

- name: docker
run: docker pull thesofproject/sof && docker tag thesofproject/sof sof

Expand Down
13 changes: 0 additions & 13 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,16 +139,3 @@ jobs:
PLATFORM: ${{ matrix.platform }}
run: ./scripts/docker-qemu.sh
../sof.git/scripts/qemu-check.sh ${PLATFORM}

yamllint-gh:
name: yamllint /.github/workflows/
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@v2

- name: apt install yamllint
run: sudo apt-get -y install yamllint

- name: yamllint github actions
run: yamllint .github/workflows/pull-request.yml
3 changes: 0 additions & 3 deletions .github/workflows/zephyr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ jobs:
# From time to time this will catch a git tag and change SOF_VERSION
with: {fetch-depth: 10, submodules: recursive}

- name: yamllint ourselves
run: yamllint .github/workflows/zephyr.yml

- name: build
run: docker run -v "$(pwd)":/workdir
docker.io/zephyrprojectrtos/zephyr-build:v0.17.3
Expand Down

0 comments on commit 0a1029c

Please sign in to comment.