case-lib: remove check for log ldc file #1215
Conversation
Checking for ldc (log dictionary) file existance as a way to decide whether to enable or disable logging during a test case, is no longer applicable as SOF supports multiple firmware logging solutions that do not use an ldc file. Remove the check as it no longer makes sense. Link: https://github.com/thesofproject/sof/issues/9286 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
|
@marc-hb wrote:
I had this at first, but then started questioning whether adding more conditions makes sense. "is_firmware_file_zephyr" is still heuristics as there's nothing stopping from using sof-logger with Zephyr. So to ease maintainance, why not reduce number of combinations we supprot. I.e. if you want to use sof-test with stable-v2.2 you should have a proper DUT setup with an ldc file to run tests. Period. |
|
Btw, this doesn't yet fix the check-sof-logger test case, but this does get FW logs back in other tests. |
There was a problem hiding this comment.
Ok you convinced me, let's remove this. In fact we still have two other ways to disable logging: -s in most tests and some environment variable, see 982f92d and #811 where this was discussed.
I think it was IPC4 migration time with more configurations and transitions that we have now.
I see check-sof-logger is still failing but now we have FW logs back thanks to this.
Just for the record, the loss of firmware logs (and other regressions) came from the big UUID PR thesofproject/sof#9261 which was merged broken
Checking for ldc (log dictionary) file existance as a way to decide whether to enable or disable logging during a test case, is no longer applicable as SOF supports multiple firmware logging solutions that do not use an ldc file.
Remove the check as it no longer makes sense.
Link: #1216