Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intel_debug: add info for Intel firmware and tplg filenames #475

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

kv2019i
Copy link
Contributor

@kv2019i kv2019i commented Sep 19, 2023

Add tables documenting the firmare and topology filenames and their
locations, as expected by Linux SOF driver.

Related to ongoing discussions in:

Add note that sof-tgl.ri is just one example firmware file
name.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo and one confusing statement @kv2019i

All good otherwise for me.

getting_started/intel_debug/introduction.rst Outdated Show resolved Hide resolved
getting_started/intel_debug/introduction.rst Outdated Show resolved Hide resolved
plbossart
plbossart previously approved these changes Sep 19, 2023
ujfalusi
ujfalusi previously approved these changes Sep 19, 2023
deb-intel
deb-intel previously approved these changes Sep 19, 2023
Copy link
Collaborator

@deb-intel deb-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor grammatical improvements to incorporate.

getting_started/intel_debug/introduction.rst Outdated Show resolved Hide resolved
getting_started/intel_debug/introduction.rst Outdated Show resolved Hide resolved
getting_started/intel_debug/introduction.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

getting_started/intel_debug/introduction.rst Outdated Show resolved Hide resolved
mengdonglin
mengdonglin previously approved these changes Sep 20, 2023
Add tables documenting the firmare and topology filenames and their
locations, as expected by Linux SOF driver.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202309-sof-fw-tplg-file-layout branch from 706101a to b959e84 Compare September 20, 2023 07:12
@kv2019i
Copy link
Contributor Author

kv2019i commented Sep 20, 2023

Thanks for reviews. @deb-intel and @marc-hb I merged your wording suggestions to a new version.

@marc-hb marc-hb merged commit 3c934c7 into thesofproject:master Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants