ASoC: SOF: ipc4-pcm: Add fixup for channels #5441
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can have modules in path which can change the number of channels and in this case the BE params needs to be adjusted to configure the DAI according to the copier configuration. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta and
bardliao
as code owners
bardliao
reviewed
Jun 3, 2025
| * module which can change the number of channels. But we do require | ||
| * topology to define a single channels in the DAI copier config in | ||
| * this case (FE channels may be variable). | ||
| */ |
There was a problem hiding this comment.
What should we do if fe_be_match = true but single_be_channels = false? I.e. One of the pin formats matches the fe channels.
There was a problem hiding this comment.
@bardliao, then we don't need to do anything, no fixup is needed, the FE channels are the same as the BE.
bardliao
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have modules in path which can change the number of channels and in this case the BE params needs to be adjusted to configure the DAI according to the copier configuration.