Skip to content

Conversation

@bardliao
Copy link
Collaborator

@bardliao bardliao commented Mar 5, 2025

When a stream's state is marked as prepared, it is ready for playback/capture. Therefore, we need to include the stream's bandwidth when we calculate the required bandwidth of a bus.

Fixes: 25befdf ("soundwire: generic_bandwidth_allocation: count the bandwidth of active streams only")

Fixes: #5334

@ranj063
Copy link
Collaborator

ranj063 commented Mar 5, 2025

@bardliao does this fix an issue? Do we have a link for that issue?

@bardliao
Copy link
Collaborator Author

bardliao commented Mar 6, 2025

@bardliao does this fix an issue? Do we have a link for that issue?

Yes, add "Fixes: #5334" to the PR message

@ranj063
Copy link
Collaborator

ranj063 commented Mar 6, 2025

@bardliao does this fix an issue? Do we have a link for that issue?

Yes, add "Fixes: #5334" to the PR message

@bardliao you need to add a "Link: ..." with that issue link in the PR commit message

@bardliao bardliao force-pushed the fix-soundwire-bandwidth-count branch from 51ec2cf to 326d45e Compare March 6, 2025 05:44
When a stream's state is marked as prepared, it is ready for
playback/capture. Therefore, we need to include the stream's bandwidth
when we calculate the required bandwidth of a bus.

Fixes: 25befdf ("soundwire: generic_bandwidth_allocation: count the bandwidth of active streams only")
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: thesofproject#5334
@bardliao bardliao force-pushed the fix-soundwire-bandwidth-count branch from 326d45e to 3d2b712 Compare March 6, 2025 05:47
@bardliao
Copy link
Collaborator Author

bardliao commented Mar 6, 2025

@bardliao does this fix an issue? Do we have a link for that issue?

Yes, add "Fixes: #5334" to the PR message

@bardliao you need to add a "Link: ..." with that issue link in the PR commit message

Done

@bardliao bardliao merged commit 633555e into thesofproject:topic/sof-dev Mar 7, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDW Amp feedback not working on 6.14-rc3 or sof/linux - bus clashes

3 participants