[BUG] No sound Lenovo X1 Fold 16 Gen 1

[leskunberg]

Describe the bug
No sound comes from any of the unit speakers(There are 3). The configuration seems correct. The DMIC works correctly. Bluetooth works correctly. Using the USB-C port to a headphone jack also works correctly.

To Reproduce
Install arch linux with kernel 6.12.4 then boot the laptop. Same result with Ubuntu 24.10

Reproduction Rate
Always

Expected behavior
Sound should come from the speakers

Impact
No audio, which is annoying

Environment

1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
   • Kernel: 6.12.4
   • SOF: 2024.09.2-1
2. Name of the topology file
   • Topology: I've tried a few, all fail to produce sound
3. Name of the platform(s) on which the bug is observed.
   • Platform: Lenovo X1 Fold 16 Gen 1

Screenshots or console output

Alsa-info

Any help would be greatly appreciated!

[kv2019i]

Hmm, SOF firmware is loading fine, PCH-DMIC and HDMI/DP seem to be working find, but no codecs found for speakers. The alsa-info has this:

Realtek 0x000232025d131601
Realtek 0x000030025d131601

... so looks like a pair of RT1316. @bardliao @ujfalusi is this a configuration we've seen before?

[bardliao]

Hmm, SOF firmware is loading fine, PCH-DMIC and HDMI/DP seem to be working find, but no codecs found for speakers. The alsa-info has this:

Realtek 0x000232025d131601 Realtek 0x000030025d131601

... so looks like a pair of RT1316. @bardliao @ujfalusi is this a configuration we've seen before?

No, it looks like a speaker only configuration. @leskunberg Can you confirm that there is no jack supported by the laptop?

[ujfalusi]

According to https://www.lenovo.com/ie/en/p/laptops/thinkpad/thinkpadx1/thinkpad-x1-fold/len101t0047#ports_slots, it has not jack.

[leskunberg]

Hmm, SOF firmware is loading fine, PCH-DMIC and HDMI/DP seem to be working find, but no codecs found for speakers. The alsa-info has this:
Realtek 0x000232025d131601 Realtek 0x000030025d131601
... so looks like a pair of RT1316. @bardliao @ujfalusi is this a configuration we've seen before?

No, it looks like a speaker only configuration. @leskunberg Can you confirm that there is no jack supported by the laptop?

I can confirm it does not have a headphone jack. As a work around I was using a USB-C to 2.5mm converter. That is working without any problems on all USB-C ports.

[bardliao]

@leskunberg Can you try #5275? And the topology file:
sof-adl-rt1316-l02.zip

[leskunberg]

@leskunberg Can you try #5275? And the topology file: sof-adl-rt1316-l02.zip

The kernel referenced in #5275 has been built and it has attempted to load the topology file. Here is the resulting alsa-info

A noteworthy part:

[    7.371911] snd_sof:sof_select_ipc_and_paths: sof-audio-pci-intel-tgl 0000:00:1f.3: Module parameter used, changed tplg path to /usr/lib/firmware/intel/sof-tplg
[    7.371913] snd_sof:sof_select_ipc_and_paths: sof-audio-pci-intel-tgl 0000:00:1f.3: Module parameter used, changed tplg name to sof-adl-rt1316-l02.tplg
[    7.376314] snd_sof:sof_test_topology_file: sof-audio-pci-intel-tgl 0000:00:1f.3: Failed to open topology file: /usr/lib/firmware/intel/sof-tplg/sof-adl-rt1316-l02.tplg
[    7.376319] sof-audio-pci-intel-tgl 0000:00:1f.3: SOF firmware and/or topology file not found.
[    7.377975] sof-audio-pci-intel-tgl 0000:00:1f.3: Supported default profiles
[    7.377977] sof-audio-pci-intel-tgl 0000:00:1f.3: - ipc type 0 (Requested):
[    7.377978] sof-audio-pci-intel-tgl 0000:00:1f.3:  Firmware file: intel/sof/sof-adl.ri
[    7.377980] sof-audio-pci-intel-tgl 0000:00:1f.3:  Topology file: intel/sof-tplg/sof-adl-rt1316-l02.tplg
[    7.377981] sof-audio-pci-intel-tgl 0000:00:1f.3: Verify the path/name override module parameters.

The file certainly exists

[leif@x1 ~]$ ls -lah /usr/lib/firmware/intel/sof-tplg/sof-adl-rt1316-l02.tplg
-rw-r--r-- 1 root root 33K Dec 17 02:52 /usr/lib/firmware/intel/sof-tplg/sof-adl-rt1316-l02.tplg

Pacman output showing sof-firmware:

[leif@x1 ~]$ pacman -Q | grep sof
sof-firmware 2024.09.2-1
sof-tools 2024.09.2-1

Does the topology file require special handling? I am loading it with the following modprobe:

[leif@x1 ~]$ cat /etc/modprobe.d/test-sof.conf 
options snd_sof_pci tplg_path=/usr/lib/firmware/intel/sof-tplg tplg_filename=sof-adl-rt1316-l02.tplg

[ujfalusi]

@leskunberg, the path should be relative to the firmware dir, so:

options snd_sof_pci tplg_path=intel/sof-tplg tplg_filename=sof-adl-rt1316-l02.tplg

But in theory you can drop both the path and the filename parameter.

[ujfalusi]

@leskunberg, there is really no need to specify the tplg_path via module parameter, it is the default one anyways.

[leskunberg]

@leskunberg, the path should be relative to the firmware dir, so:

options snd_sof_pci tplg_path=intel/sof-tplg tplg_filename=sof-adl-rt1316-l02.tplg

But in theory you can drop both the path and the filename parameter.

Thank you @ujfalusi ! That did it. Here is the updated alsa-info

[    6.304077] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI ALH3.IN stream SDW0-Capture
[    6.305845] sof-audio-pci-intel-tgl 0000:00:1f.3: failed to add widget type 28 name : ALH3.IN stream SDW0-Capture
[    6.312068] sof-audio-pci-intel-tgl 0000:00:1f.3: error: tplg component load failed -22
[    6.314091] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to load DSP topology -22
[    6.315775] sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22