request for rt5514 topology #22
Comments
|
Hi, topology for rt5514 was added in d4d8936 I can also help with UCMs, but would need to see what pulseaudio thinks that name of machine should be. |
|
Sorry for the delayed response. This is what it comes back with. Please let me know if I can provide anything else! |
|
It just occurred to me that I did not do this with avs enabled. I will rerun it shortly with avs enabled. |
|
Unfortunately it looks like with AVS enabled I'm hitting a new issue: |
|
After trying a bunch of different kernels, etc. I discovered downgrading alsa-sof-firmware to alsa-sof-firmware-2023.09.2-1.fc39.noarch stops the above trace from happening. Moving up available packages 2023.12.1 or newer causes the errors above to reappear in dmesg. I don't know if anyone on this issue or @WeirdTreeThing might have an idea what might be the cause of that. With the old firmware the old 6.7.rc0 kernel I had built I have audio. With 6.8.10 something has changed and though Anyway, the output you requested: |
|
I've already made UCMs for Google Eve, you can check them here and let me know how it goes: alsa-project/alsa-ucm-conf#418 When it comes to the kernel splat, it seems like it fails while loading topology - are those alsa-sof-firmware packages you mentioned available somewhere online, so I can see what files are packaged and what may have gone wrong? (I tried quick search, but haven't found anything sensible.) We also did a release with built topology files: https://github.com/thesofproject/avs-topology-xml/releases/tag/v2024.02 so you can try with that instead of your distribution ones? |
|
I'll work on giving the UCMs for Eve and topoloxy you linked a try. It's late (early now) here so it'll probably be a few hours sleep in between now and then. The alsa-sof-firmware packages I am using are available in koji: Judging by the rpm spec it looks like the source for these are https://github.com/thesofproject/sof-bin and a few others repos I landed on 2023.09.2 because when we last tested this and got it mostly working it was in November and it seemed likely the version I'd have installed then. I started looking at firmware because the kernel I built back then wasn't working now either. Apologies if I am explaining stuff you already know: if you download and want to extract any of the rpms from koji you can |
|
Yes, for the newer ones alsa-sof-firmware also includes the package I mentioned. So I've built v6.8.10 kernel, as that's the version you seem to use and put topologies from our package along with proper FW file and it seems to have loaded properly. So I suspect some kind of integration issue on distribution side. However I've compared md5sum of few files from Fedora package and the ones in avs-topology-xml release and they seem fine. Can you share a bit more of dmesg log? It should be logging which topology it tries to load (and if not additional debug level can be enabled to see it). |
|
Good news, it seems it's just outdated topology files in the alsa-sof-firmware package in Fedora. The easiest way I could see what was trying to be loaded was to just uninstall the package: From there I just copied those in from https://github.com/thesofproject/avs-topology-xml/releases/tag/v2024.02 No more splat at that point. Then I copied in your UCMs and have working audio. And in case it looks any different the answer to your original question: |
|
OK, so they're not out of date.
So, I think there is something going wrong handling the compressed topology files. The reason the 2023.09.2 didn't cause the splat and 2023.12.1 and newer did is simply because from 12.1 on the avs files are included. When we originally got this working back in November the topology files I was using were uncompressed so there was no issue and I had used those earlier today/last night to get 6.7 working, but the new alsa-sof-firmware package is problematic even with that old kernel so it's probably been an issue all along. |
|
Maybe something along the lines of this. It I'm a little confused if it is the same though, because I tried zstd compression since the Fedora kernel supports it as well, and it worked. Maybe the two work a little differently. Anyway, I can open a bug elsewhere if it makes sense, since this is deviating from the original request. |
|
Yes, I was also wondering a bit if it is because files are packed, will investigate this. I suspect it may be due to fact that we have caching mechanism in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/intel/avs/utils.c?h=v6.10-rc1#n235 |
|
So it seems that it was unrelated to caching mechanism. Fix is available at https://lore.kernel.org/linux-sound/20240603102818.36165-1-amadeuszx.slawinski@linux.intel.com/T/#t |
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this issue
Jun 3, 2024
Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this issue
Jun 3, 2024
Instead of overriding existing memory strings that may be too short, just allocate needed memory and point the route at it. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
|
I built a kernel with these patches and can confirm they fixed the issue. |
plbossart
pushed a commit
to plbossart/sound
that referenced
this issue
Jun 12, 2024
Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
plbossart
pushed a commit
to plbossart/sound
that referenced
this issue
Jun 12, 2024
Instead of overriding existing memory strings that may be too short, just allocate needed memory and point the route at it. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-3-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
plbossart
pushed a commit
to plbossart/sound
that referenced
this issue
Jun 12, 2024
Merge series from Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>: Originally reported here: thesofproject/avs-topology-xml#22 (comment) There is various level of failure there, first of all when topology loads routes, it points directly into FW file, but it may be freed after topology load. After fixing the above, when avs driver parses topology it should allocate its own memory, as target strings can be shorter than needed. Also clean up soc_tplg_dapm_graph_elems_load() a bit.
|
Looks like the issue is resolved. Thank you for your report @jmontleon, and Amadeusz for addressing it. |
|
For bookkeeping: the missing topology addressed with PR #25, commit [1]: d4d8936 |
brauner
pushed a commit
to brauner/linux
that referenced
this issue
Jul 18, 2024
Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
brauner
pushed a commit
to brauner/linux
that referenced
this issue
Jul 18, 2024
Instead of overriding existing memory strings that may be too short, just allocate needed memory and point the route at it. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-3-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
brauner
pushed a commit
to brauner/linux
that referenced
this issue
Jul 18, 2024
Merge series from Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>: Originally reported here: thesofproject/avs-topology-xml#22 (comment) There is various level of failure there, first of all when topology loads routes, it points directly into FW file, but it may be freed after topology load. After fixing the above, when avs driver parses topology it should allocate its own memory, as target strings can be shorter than needed. Also clean up soc_tplg_dapm_graph_elems_load() a bit.
mj22226
pushed a commit
to mj22226/linux
that referenced
this issue
Jul 23, 2024
[ Upstream commit 97ab304 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
mj22226
pushed a commit
to mj22226/linux
that referenced
this issue
Jul 23, 2024
[ Upstream commit 97ab304 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
johnny-mnemonic
pushed a commit
to linux-ia64/linux-stable-rc
that referenced
this issue
Jul 24, 2024
[ Upstream commit 97ab304 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
johnny-mnemonic
pushed a commit
to linux-ia64/linux-stable-rc
that referenced
this issue
Jul 24, 2024
[ Upstream commit fd660b1 ] Instead of overriding existing memory strings that may be too short, just allocate needed memory and point the route at it. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-3-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi
pushed a commit
to Whissi/linux-stable
that referenced
this issue
Jul 25, 2024
[ Upstream commit 97ab304 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi
pushed a commit
to Whissi/linux-stable
that referenced
this issue
Jul 25, 2024
[ Upstream commit 97ab304 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi
pushed a commit
to Whissi/linux-stable
that referenced
this issue
Jul 25, 2024
[ Upstream commit fd660b1 ] Instead of overriding existing memory strings that may be too short, just allocate needed memory and point the route at it. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-3-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi
pushed a commit
to Whissi/linux-stable
that referenced
this issue
Jul 25, 2024
[ Upstream commit 97ab304 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
opsiff
pushed a commit
to opsiff/UOS-kernel
that referenced
this issue
Jul 29, 2024
[ Upstream commit 97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> (cherry picked from commit ab5a6208b4d6872b1c6ecea1867940fc668cc76d)
Dangku
pushed a commit
to Dangku/sunxi-linux
that referenced
this issue
Aug 7, 2024
[ Upstream commit 97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: August <2819763+Dangku@users.noreply.github.com>
Avenger-285714
pushed a commit
to deepin-community/kernel
that referenced
this issue
Aug 12, 2024
[ Upstream commit 97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> (cherry picked from commit ab5a6208b4d6872b1c6ecea1867940fc668cc76d)
jhautbois
pushed a commit
to YoseliSAS/linux
that referenced
this issue
Aug 21, 2024
Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
jhautbois
pushed a commit
to YoseliSAS/linux
that referenced
this issue
Aug 21, 2024
Instead of overriding existing memory strings that may be too short, just allocate needed memory and point the route at it. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-3-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
wanghao75
pushed a commit
to openeuler-mirror/kernel
that referenced
this issue
Sep 12, 2024
mainline inclusion from mainline-v6.10-rc6 commit 97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IAGELE CVE: CVE-2024-41069 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 -------------------------------- Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Conflicts: sound/soc/soc-topology.c [Resolve conflicts due to some cleanup commits not backported] Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Fixes: 8a97823 ("ASoC: topology: Add topology core") Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
wanghao75
pushed a commit
to openeuler-mirror/kernel
that referenced
this issue
Sep 12, 2024
mainline inclusion from mainline-v6.10-rc6 commit 97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IAGELE CVE: CVE-2024-41069 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 -------------------------------- Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Conflicts: sound/soc/soc-topology.c [Resolve conflicts due to some cleanup commits not backported] Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Fixes: 8a97823 ("ASoC: topology: Add topology core") Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
wanghao75
pushed a commit
to openeuler-mirror/kernel
that referenced
this issue
Sep 12, 2024
mainline inclusion from mainline-v6.10-rc6 commit 97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/IAGELE CVE: CVE-2024-41069 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1 -------------------------------- Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Conflicts: sound/soc/soc-topology.c [Resolve conflicts due to some cleanup commits not backported] Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Fixes: 8a97823 ("ASoC: topology: Add topology core") Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
tuxedo-bot
pushed a commit
to tuxedocomputers/linux
that referenced
this issue
Sep 13, 2024
BugLink: https://bugs.launchpad.net/bugs/2078304 [ Upstream commit 97ab304 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Portia Stephens <portia.stephens@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tuxedo-bot
pushed a commit
to tuxedocomputers/linux
that referenced
this issue
Sep 13, 2024
BugLink: https://bugs.launchpad.net/bugs/2078304 [ Upstream commit fd660b1 ] Instead of overriding existing memory strings that may be too short, just allocate needed memory and point the route at it. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-3-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Portia Stephens <portia.stephens@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tuxedo-bot
pushed a commit
to tuxedocomputers/linux
that referenced
this issue
Sep 27, 2024
BugLink: https://bugs.launchpad.net/bugs/2078304 [ Upstream commit 97ab304 ] Most users after parsing a topology file, release memory used by it, so having pointer references directly into topology file contents is wrong. Use devm_kmemdup(), to allocate memory as needed. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Portia Stephens <portia.stephens@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tuxedo-bot
pushed a commit
to tuxedocomputers/linux
that referenced
this issue
Sep 27, 2024
BugLink: https://bugs.launchpad.net/bugs/2078304 [ Upstream commit fd660b1 ] Instead of overriding existing memory strings that may be too short, just allocate needed memory and point the route at it. Reported-by: Jason Montleon <jmontleo@redhat.com> Link: thesofproject/avs-topology-xml#22 (comment) Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20240603102818.36165-3-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Portia Stephens <portia.stephens@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was looking to test / use the patch set at:
https://patchwork.kernel.org/project/alsa-devel/list/?series=797110&state=%2A&archive=both
From conversation at jmontleon/pixelbook-fedora#67 (comment) it sounds like I'll probably need a topology file to proceed.
The text was updated successfully, but these errors were encountered: