Merged
Conversation
This commit adds a new `channel-management` helper to Valkyrie which will always ensure permissions on new channels within the `defense` category are assigned to the same permission set as the channel category permissions. It then sends a message to the newly created channel, listing the permissions and access levels they have.
Member
Author
|
Also marking this one ready to review, if we want to get the permission mapper for #defense cat pushed before our next release. |
Shadowfiend
previously approved these changes
Mar 11, 2024
Contributor
Shadowfiend
left a comment
Shadowfiend
left a comment
There was a problem hiding this comment.
This is pretty much good to go.
I will leave it up to you if you want to merge & then address in one of the following PRs, or if you want to address & then we merge.
Open
- Removes list of permissions sent to channel - Changes defense to load from specific channel id. You must setup env `DEFENSE_CATEGORY_ID` to have it function correctly. - Merges into one function
Member
Author
|
@Shadowfiend Thanks for the review comments and have now fixed this up so it's ready to be merged. Just need to add env |
Shadowfiend
reviewed
Mar 12, 2024
Comment on lines
+9
to
+10
| if (process.env.DEFENSE_CATEGORY_ID) { | ||
| if (application) { |
Contributor
There was a problem hiding this comment.
No need to nest, these can combine into one.
This has already been applied.
Shadowfiend
approved these changes
Mar 12, 2024
Contributor
Shadowfiend
left a comment
Shadowfiend
left a comment
There was a problem hiding this comment.
Pushed a commit with the kube config updates. Let's do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
This commit adds a new
channel-managementhelper to Valkyrie which will always ensure permissions on new channels within thedefensecategory are assigned to the same permission set as the base channel category permissions.It then sends a message to the newly created channel, listing the permissions and access levels they have for quick verification on channel permissions.
If the channel is created with different permissions than base category, it will be overwritten by the permissions on base category. However, permissions can also be altered after creation if needed manually.
Screenshot