Skip to content

feat: add native-tls support #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

feat: add native-tls support #71

merged 1 commit into from
May 31, 2024

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented May 30, 2024

RFC: Should the feature flags be named native-tls / rustls-tls to better align with the reqwest library where these features are being enabled, or tls-native-tls / tls-rustls to align calling libraries like sqlx (e.g. https://github.com/launchbadge/sqlx/blob/main/Cargo.toml#L79-L81)...?

@github-actions github-actions bot added the enhancement New feature or request label May 30, 2024
Copy link
Contributor

🐰Bencher

ReportThu, May 30, 2024 at 21:22:16 UTC
Projecttheseus-rs/postgresql-embedded
Branchnative-tls-support
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
extract➖ (view plot)152,880.00
lifecycle➖ (view plot)1,151,900,000.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (18692bb) to head (717eb1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          57       57           
  Lines        7522     7522           
=======================================
  Hits         7487     7487           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit fc06580 into main May 31, 2024
14 checks passed
@brianheineman brianheineman deleted the native-tls-support branch May 31, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant