Skip to content

fix: use tokio::process::spawn() for pc_ctl on Windows #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Jan 17, 2025

Address #99

@github-actions github-actions bot added the fix Bug fix label Jan 17, 2025
@brianheineman brianheineman force-pushed the spawn-pg-ctl-on-windows-async branch 2 times, most recently from 581bc4e to 7884de0 Compare January 17, 2025 17:43
Copy link
Contributor

github-actions bot commented Jan 17, 2025

🐰 Bencher Report

Branchspawn-pg-ctl-on-windows-async
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
extract📈 view plot
⚠️ NO THRESHOLD
203.30
lifecycle📈 view plot
⚠️ NO THRESHOLD
2,567,200.00
🐰 View full continuous benchmarking report in Bencher

@brianheineman brianheineman force-pushed the spawn-pg-ctl-on-windows-async branch from 7884de0 to e93b944 Compare January 17, 2025 17:46
@brianheineman brianheineman merged commit 7ef29da into main Jan 17, 2025
11 checks passed
@brianheineman brianheineman deleted the spawn-pg-ctl-on-windows-async branch January 17, 2025 17:59
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.08%. Comparing base (01977bd) to head (e93b944).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
postgresql_commands/src/traits.rs 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   99.12%   99.08%   -0.05%     
==========================================
  Files          71       71              
  Lines        9189     9190       +1     
==========================================
- Hits         9109     9106       -3     
- Misses         80       84       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant