Multicore step 0 - Prepare multicore_bringup for aarch64 port
#889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinaboos
approved these changes
Mar 20, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Move `multicore_bringup/lib.rs` to x86_64-specific module file. * Remove `max_framebuffer_resolution` parameter in `multicore_bringup`, use the fixed constant definition from `kernel_config`. * Restore arch-gate for early exceptions init in `nano_core` db6f3a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change any instruction except that the max_framebuffer_resolution parameter of
handle_ap_coreswas removed, as it was always set to something from kernel_config.The rest of the changes are related to the directory layout of the crate as well as its manifest.
This is a dependency of #890.