pte_flags
bilge conversion [draft]
#1085
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my partial bilge conversion of
pte_flags
.At this point the only thing I converted was the
PteFlagsAarch64
struct, I didn't update the methods from the bitflags era.As such, this doesn't compile, but the definition of that struct should be correct.
When the field is defined as an enum, I moved the field documentation to the enum, not sure if that's a good thing to do.