Typescript 5 breaking compilation

[khang-at-sri]

It appears the version for Typescript wasn't locked down which allowed the installation of Typescript 5 instead of 4.x when doing a fresh npm install -g. This breaks the compilation process, producing an error along the lines of:

TypeError: Cannot create property 'pos' on string 'fields'

[curquhart]

+1

[SKTT1Ryze]

+1
https://code.mycard.moe/mycard/neos-protobuf/-/jobs/82799

[SKTT1Ryze]

How can i solve this problem?

[LucasXu0]

+1

[thesayyn]

I can confirm. Does anybody mind sending a PR for it?

[SKTT1Ryze]

I can confirm. Does anybody mind sending a PR for it?

I manually replace the version of typescript in /Users/username/.nvm/versions/node/v18.9.0/lib/node_modules/protoc-gen-ts/package.json with 4.9.x and it works:

{
    ...
    "devDependencies": {
    ...
    "typescript": "^4.3.4" -> "4.9.x"
  }
}

Should we solve this issue by this way?

And it seems that it's a problem within 0.8.5 release, not the main branch. Do you mean a PR for 0.8.5 release branch?

[thesayyn]

that's the principled fix here. main also has this problem.

NOTE: typescript has been causing a lot of problems lately. I'll ship it bundled.

[xqi-aviatrix]

+1. Can anyone help fix the issue in the code and publish a release?
We are hitting the similar issue in our github workflow where we have little control about the installed libs.

/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/node_modules/typescript/lib/typescript.js:20482
      array.pos = -1;
                ^
TypeError: Cannot create property 'pos' on string 'id'
    at createNodeArray (/opt/hostedtoolcache/node/18.[15](https://github.com/AviatrixDev/proto-registry/actions/runs/4494178171/jobs/7906335301#step:9:16).0/x64/lib/node_modules/protoc-gen-ts/node_modules/typescript/lib/typescript.js:20482:17)
    at Object.createGetAccessorDeclaration (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/node_modules/typescript/lib/typescript.js:21028:25)
    at createGetter (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/descriptor.js:320:50)
    at createMessage (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/descriptor.js:719:25)
    at Object.processDescriptorRecursively (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/descriptor.js:752:9)
    at /opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/index.js:47:82
    at Array.flatMap (<anonymous>)
    at Object.<anonymous> (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/index.js:47:40)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
Node.js v18.15.0
/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/node_modules/typescript/lib/typescript.js:20482
      array.pos = -1;
                ^
TypeError: Cannot create property 'pos' on string 'paths'
    at createNodeArray (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/node_modules/typescript/lib/typescript.js:20482:[17](https://github.com/AviatrixDev/proto-registry/actions/runs/4494178171/jobs/7906335301#step:9:18))
    at Object.createGetAccessorDeclaration (/opt/hostedtoolcache/node/[18](https://github.com/AviatrixDev/proto-registry/actions/runs/4494178171/jobs/7906335301#step:9:19).15.0/x64/lib/node_modules/protoc-gen-ts/node_modules/typescript/lib/typescript.js:21028:25)
    at createGetter (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/descriptor.js:320:50)
    at createMessage (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/descriptor.js:7[19](https://github.com/AviatrixDev/proto-registry/actions/runs/4494178171/jobs/7906335301#step:9:20):25)
    at Object.processDescriptorRecursively (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/descriptor.js:752:9)
    at /opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/index.js:47:82
    at Array.flatMap (<anonymous>)
    at Object.<anonymous> (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/protoc-gen-ts/src/index.js:47:40)
    at Module._compile (node:internal/modules/cjs/loader:1[25](https://github.com/AviatrixDev/proto-registry/actions/runs/4494178171/jobs/7906335301#step:9:26)4:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
Node.js v18.15.0

[LucasXu0]

FYI. Here's a workaround.

npm install -g protoc-gen-ts typescript@4.9.5