Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if cache size is too small for CFG #132

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

DocShotgun
Copy link
Member

Is your pull request related to a problem? Please describe.
Users who do not specify a cache_size manually will end up with a default cache that is too small for CFG.

Why should this feature be added?
This warns the user that they should set the cache_size to at least 2 * max_seq_len to avoid running out of pages when prompting with CFG.

Examples
N/A

Additional context
This will warn the user that #119 may occur.

@turboderp turboderp merged commit dcd9428 into theroyallab:main Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants