Upgrade ci php versions #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since many versions are EOL, worth supporting much one to check we can run in the latest versions too.
pieterocp
commented
Jun 11, 2025
.github/workflows/ci.yml
Outdated
|
|
||
| cs: | ||
| name: Codestyle check on PHP 7.2 | ||
| name: Codestyle check on PHP 8.3 |
There was a problem hiding this comment.
This is a very opinionated take, really it makes sense to continue development, linting + additional checks in the lowest supported version, then polyfill + run tests upwards, ergo removing this now.
…opping earlier version support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to use the latest php versions, so we can be more sure any fixes should work on a nice range of php versions.
Seem to be all passing on my fork, upgraded
shivammathur/setup-phptoo while at it since presumably there's some performance gains hidden in there.