Skip to content

Add createCard to the list on generally available actions #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 13, 2018

I'm proposing we add createCard to the list of actions as it is a key action IMHO.

The general case is that credit card details are passed in and a cardReference is returned (available by getCardReference) this can generally be used instead of credit card details in later requests.

I'm struggling a little with the Paypal Rest integration on this front as it's possible to 'create a card' when there is no card details (in the Paypal button implementation a the person is redirected to Paypal & returns with a token that if functionally equivalent to one the generic concept of 'createCard' so I though at least adding the concept into the readme is a step forwards.

@barryvdh
Copy link
Member

I think we can do this. It seems also fetchIssuers is mssing here.

@eileenmcnaughton
Copy link
Contributor Author

I don't even know what fetchIssuers does :-)

@judgej
Copy link
Member

judgej commented Aug 16, 2018

Other gateways share PayPal's concept of a "card token" as being a generic token that gives the application the ability to use some pre-authorised payment method, whether a card, bank account, direct debit, giropay etc.

The issuers I think is a little more tricky. Issuers are about who issues a payment method, and I always thought it only makes sense in the context of a payment method, but I am not entirely sure. For example Adyen can provide a list of card types available, and for some of those card types a list of issuers. The shop can then choose which issuers to use. It may accept Visa from Bank A, or Mastercard from banks A or B, but not C. It's more common in the EC outside of the UK, so not something I am entirely familiar with, but hopefully that should give you a lead.

@aimeos
Copy link

aimeos commented Nov 16, 2018

We use @judgej card token implementation for different drivers, e.g.

@judgej
Copy link
Member

judgej commented Mar 16, 2019

Is is worth adding updateCard and deleteCard to the docs here?

See https://github.com/thephpleague/omnipay-common/blob/master/src/Common/GatewayInterface.php#L33

@barryvdh barryvdh merged commit d8b5037 into thephpleague:master Jun 1, 2021
@eileenmcnaughton eileenmcnaughton deleted the patch-3 branch June 1, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants