Remove hardcoded values in ExpressAuthorizeRequest (Fixes #121) #140
Conversation
| @@ -41,6 +40,12 @@ public function getData() | |||
| $data['HDRIMG'] = $headerImageUrl; | |||
| } | |||
|
|
|||
| if ($noShipping = $this->getNoShipping()) { | |||
There was a problem hiding this comment.
This will break if you set it to '0'
There was a problem hiding this comment.
Just need to test against null instead of falsey
There was a problem hiding this comment.
Of course. Fixed now. :)
|
There's another parameter that is hardcoded (ALLOWNOTE), should this be made configurable as well? |
|
Yes, would be good to make that an option too. The only reason the defaults were there is that was what I needed for my shopping cart, but I should really move that logic into the app anyway. I'd be happy to remove the defaults and release it as 1.1, I don't think it's a major change. — On Tue, Oct 1, 2013 at 12:37 AM, Alexander Deruwe
|
|
Ah forgot to comment that I added configurable ALLOWNOTE, removed the defaults. |
Remove hardcoded values in ExpressAuthorizeRequest (Fixes #121)
|
Looks good, thanks! |
Remove hardcoded values in ExpressAuthorizeRequest (Fixes #121)
No description provided.