Remove the encrypted payload from AuthCode and RefreshToken #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Auth Code and Refresh Token information can be stored in the repository and doesn't have to go in the payload. This will reduce auth code and refresh token size, but will require more calls to the repository
userIdentifier -> UserEntity
formatting formatting formatting fix backward compatibility bump lcobucci/jwt
The Auth Code and Refresh Token information can be stored in the repository and doesn't have to go in the payload. This will reduce auth code and refresh token size, but will require more calls to the repository
userIdentifier -> UserEntity
|
Hi @craigp1231 - is it possible to bring this in line with master so I can review? I was also wondering if you could outline why you want this change. Historically, we have deliberately set the library up this was to reduce repository access overhead. I'd be keen to understand why the token size is an issue. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Auth Code and Refresh Token information can be stored in the repository and doesn't have to go in the payload. This will reduce auth code and refresh token size, but will require more calls to the repository.
If the user specifies an encryption key, the payload will be attempted to be encrypted or decrypted, else they are returned from the respective repositories.