Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refresh token int user ID #1436

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Fix refresh token int user ID #1436

merged 4 commits into from
Nov 14, 2024

Conversation

ssigwart
Copy link
Contributor

@ssigwart ssigwart commented Aug 8, 2024

Fixes #1435

Old refresh tokens may have int user IDs causing an exception. This fixes that.

@ssigwart ssigwart mentioned this pull request Nov 11, 2024
Closed
Sephster
Sephster reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@Sephster Sephster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Thank you for your PR. Looks like this will do the job. Apologies I didn't notice this when releasing v9

ssigwart
ssigwart commented Nov 12, 2024
View reviewed changes
Copy link
Contributor Author

@ssigwart ssigwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Thank you for your PR. Looks like this will do the job. Apologies I didn't notice this when releasing v9

No problem. Thanks for working on this project.

@Sephster Sephster merged commit fe04ef2 into thephpleague:master Nov 14, 2024
15 checks passed
@ssigwart ssigwart deleted the intUserId branch November 16, 2024 00:37
@hafezdivandari hafezdivandari mentioned this pull request Feb 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene-borovov eugene-borovov eugene-borovov left review comments

@Maksimius Maksimius Maksimius left review comments

@Sephster Sephster Sephster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v9 Typing breaks existing refresh tokens
4 participants
@ssigwart @eugene-borovov @Sephster @Maksimius