Skip to content

Conversation

@eugene-borovov
Copy link
Contributor

@Sephster I have implemented my proposal.

  • Params parsed to non-empty string
  • Scalar params cast to string
  • Empty string treats as null
  • Non-scalar params throws invalidRequest
  • Remove string checks
  • Null checks have been shorten to null-coalesce operator

I will be glad if it helps.

@eugene-borovov eugene-borovov force-pushed the fix-passport-compatibility branch from 3a6a313 to df39bf6 Compare May 6, 2024 23:18
@Sephster Sephster merged commit 7596935 into thephpleague:fix-passport-compatibility May 10, 2024
@Sephster
Copy link
Member

@eugene-borovov thank you very much for this PR. Saved me a great deal of time and looks good. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants