Add static analysis #549
Merged
Add static analysis #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Mar 9, 2022
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Im not a big fan of this. I believe PHPstan and Psalm are tools, just like PHPStorm. All three will help you two write better code and none is integrated like PHPUnit.
I am the kind of programmer that always make 2-3 commits per pull request to fix the issues after CI is run. But I also know that other people would like to fix CS issues before they push.
So I am more like ¯\(ツ)/¯. Merge it if you like.
But let's remove it if/when it causes dependency issues.
FYI, I've installed these tool globally on my machine.
Contributor
Author
|
@Nyholm thats all fair! I tend to stick to by project installs for some reason. I will merge for the moment, but like you said if the dependencies get messy we can definitely remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so this way people can run these tools locally, before they hit CI.