Skip to content

Conversation

@JustSteveKing
Copy link
Contributor

Hey all 👋

So after seeing the issue about moving to Github actions I thought I would drop in a PR. I have tried to keep this as "vague" as possible incase you want to push any of these upstream. I have matched the travis support back to PHP 5.4 for now.

@KorvinSzanto
Copy link
Contributor

Would it be better to have different jobs for testing and for CI? The benefits of that are that we'd see both code style and tests even if code style failed and we'd be able to see at a glance which parts failed.

@JustSteveKing
Copy link
Contributor Author

While I'd usually agree, the point of this PR was to migrate like for like from travis over to GitHub Actions 🙂

It begs the question, should code quality and tests be separated. If this is the case I would look to move the code quality checks to it's own workflow file instead of a separate job.

I'm open to opinions on this, and will happily refactor to whatever the concensus is here.

@JustSteveKing
Copy link
Contributor Author

@KorvinSzanto here we go! I have moved them to separate workflos now 😄

@JustSteveKing
Copy link
Contributor Author

@matthewtrask all done now buddy!

@KorvinSzanto
Copy link
Contributor

👍 Nice, I think the last steps for this to be a complete replacement would be to move the bit in .travisci that copies coverage up to scrutinizer into the tests and drop the .travisci file

@JustSteveKing
Copy link
Contributor Author

@KorvinSzanto that would be super easy to do, and I did it in the beginning, but it kept 404-ing because it ran on my repo 😂

Will get that added in the morning for you

@JustSteveKing
Copy link
Contributor Author

@KorvinSzanto here we go! It may fail to build on my local branch now but scrutinizer steps have been added, as has the updated github action readme badge - so when merged the status should swap.

@KorvinSzanto KorvinSzanto merged commit 9c9c493 into thephpleague:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants