-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library doesn't support iconv stream filter #72
Comments
This is a limitation due to poor support from |
In the meantime, nothing prevents you from modifying the FilterTranscode class to use iconv extension instead. I understand it is frustrating but if this bug was resolved a even more powerful package could be made and It would also remove the need for |
thanks for your comments, if you can't do anything about that I'll wait for the fix in the SPL. |
Yep there's nothing, a omission from my part. But you can make a pull request against the gh-pages branch to add the warning. |
I've just updated the documentation by adding a warning section on top of the stream filter documentation page. |
thank you much Ignace. |
FYI, the
The linked open PHP bug report in the docs and @nyamsprod's earlier comment indicates this doesn't work, but it appears that the filter URI support was fixed to It might be worth revising the warning in the documentation about this, at least as it relates to iconv filters specifically. |
- bug fix stream filter #72 - improve public API by deprecating (get|set)EncodingFrom
@zerocrates you are totally right seems I had overlooked this one. I've just create a PR with the fix in it. This one will be included in the next release 👍 |
That's really cool guys thanks @zerocrates for pointing the fix and thanks @nyamsprod for implementing it ;-) |
bug fix is merged in master branch |
I have the same problem. |
Same problem here ... |
and here. |
@spagu could you provide more information as this bug is related to an unsupported version of the library. It would be best to open a new thread with an example so I could investigate your issue. thanks in advance |
Hi, I just pulled the latest version of the library and try to integrate it in my application but it fails at the beginning when I do
it throws the following exception :
whereas this code works perfectly
any ideas?
The text was updated successfully, but these errors were encountered: