Don't add remaining contents to closed containers (fixes #57) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submitted test case failed because the parser tried to add an empty line to the already-closed IndentedCode block. In the JS reference parser, closing this block type results in it becoming a CodeBlock type, which we don't use, and therefore the addLine() logic doesn't run. We can mirror that behavior by ensuring nothing ever calls addLine() on a closed block.
colinodell
added a commit
that referenced
this pull request
Jan 9, 2015
Don't add remaining contents to closed containers (fixes #57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submitted test case failed because the parser tried to add an empty line to the already-closed IndentedCode block. In the JS reference parser, closing this block type results in it becoming a CodeBlock type, which we don't use, and therefore the addLine() logic doesn't run. We can mirror that behavior by ensuring nothing ever calls addLine() on a closed block.