Bugfix for HTML Element __toString() #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
added a commit
that referenced
this pull request
Jan 7, 2015
Bugfix for HTML Element __toString()
| @@ -122,7 +122,7 @@ public function __toString() | |||
| $result .= ' ' . $key . '="' . $value . '"'; | |||
| } | |||
|
|
|||
| if ($this->contents) { | |||
| if (!is_null($this->contents) and $this->contents != '') { | |||
There was a problem hiding this comment.
$this->contents should never be null, so we could remove that first check.
There was a problem hiding this comment.
It should also probably be !== ''
There was a problem hiding this comment.
also, we should use && over and.
There was a problem hiding this comment.
Thanks Graham.
@colinodell with the suggested change made, tests are reporting the following:
1) League\CommonMark\Tests\HtmlElementTest::testToString
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<p></p><img />'
+'<p></p><img></img>'
There was a problem hiding this comment.
Ugh I'm probably using null somewhere I shouldn't be. /facepalm
I'll look into this.
There was a problem hiding this comment.
Yep, that was my bad: 34884ce
|
Yeah, just looked at property declaration and the constructor, didn't think far enough that it shouldn't ever be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic was too broad, any value that could be considered false (like '0') would be treated as an empty tag.