-
Notifications
You must be signed in to change notification settings - Fork 3
improved Importations #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Noted @keosariel great work! Here a few things to note so you can update the PR accordingly:
Thank you! |
5d81e8c
to
2f0716a
Compare
* improved Importations (#1) * changed test directory * improved exception importation * improved importation * improved importation * fixed importation * added test script * moved constants * moved back * add .db_store to .gitignore * decoupled exceptions * removed .db_store Co-authored-by: kenneth gabriel <keosariel@icloud.com> * upgraded to v0.0.4 Co-authored-by: keosariel <31022243+keosariel@users.noreply.github.com> Co-authored-by: kenneth gabriel <keosariel@icloud.com>
The importation:
Doesn't look great by convention. With my modifications, the importation looks like:
And I also updated the
tests
and thereadme
to match the new build. I also removed the test folder, instead of:and I also added a one liner script to run tests