escape "_" when using LIKE operator #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioguix
added a commit
to ioguix/pgsodium
that referenced
this pull request
Jun 8, 2023
Bug reported to pgtap upstream here: theory/pgtap#311
michelp
pushed a commit
to michelp/pgsodium
that referenced
this pull request
Jun 8, 2023
* Fix test error on schema caused by pgtap bug Bug reported to pgtap upstream here: theory/pgtap#311 * Test minimal postgresql supported version * Fix test failing because of objects order the test can fail when running the test on a database with a different collation than the one used to write the test. * Fix SQL error with pg 16 * Fix test errors with pg_read_all_data and pg_write_all_data roles * Update pgsodium version in test generator * Add tests about masking_rule.security_invoker column * Comply tests generator and SQL schema to the new test.sql script * Create role and extension inside the test's transaction * Create pgsodium extension outside of the transaction When creating the extension inside the xact, one test is failing with the following error: ERROR: unsafe use of new value "secretbox" of enum type key_type LINE 1: SELECT id as secretbox_key_id from create_key('secretbox') ^ HINT: New enum values must be committed before they can be used * Make volumes accessible inside the container with podman
|
Thank you! Superseded by #312. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Function
schemas_areis currently with extensionpgsodiumbecause of bad escaping of_with theLIKEoperator.Here is a small fix.
Thanks,