Skip to content

Updates for Postgres 14 #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2021
Merged

Updates for Postgres 14 #278

merged 1 commit into from
Oct 10, 2021

Conversation

theory
Copy link
Owner

@theory theory commented Oct 9, 2021

WIP

@theory
Fix test failures on Postgres 14
6d072d9 
Due to the following changes:

*   Support for right unary (postfix) operators was dropped, so has_rightop()
    does not work (and has no operators to test against) on Postgres 14. So
    mock the test output for that function on Postgres 14.

*   The types for functions work on changed from anyelement/anyarray to
    anycompatible/anycompatiblearray. So use the appropriate types depending
    on the versin of Postgres.

*   A primary key was added to pg_catalog.pg_class, breaking tests that did
    not expect it. So create primary key-less and unique key-less tables in
    the tests that we can depend on, instead.
@theory theory marked this pull request as ready for review October 10, 2021 02:51
@theory theory requested review from decibel and df7cb October 10, 2021 02:51
This was referenced Oct 10, 2021
Closed
Closed
@theory theory merged commit 6d072d9 into master Oct 10, 2021
@theory theory deleted the 14-compat branch October 10, 2021 15:41
@feuGeneA feuGeneA mentioned this pull request Oct 13, 2021
Closed
@matthieu-foucault
Copy link

@theory what's the time frame on a 1.2.0 release of pgTap? We're looking into upgrading our postgres databases, and we have lots of pgTap tests :)
cc @pbastia @dleard

@theory
Copy link
Owner Author

theory commented Oct 15, 2021

I'd like to do it soon, but want to be sure that @nasbyj has finished his work on it, or is fine to defer it to the next release.

@theory
Copy link
Owner Author

theory commented Oct 15, 2021

Well, and to fix #279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decibel decibel Awaiting requested review from decibel

@df7cb df7cb Awaiting requested review from df7cb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theory @matthieu-foucault