only do version check on windows os #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mark-thm
approved these changes
Jul 5, 2024
alexeagle
reviewed
Jul 8, 2024
| # skip version check on windows if we don't have a release version. We can't tell from a hash what features we have. | ||
| if os == "windows" and native.bazel_version: | ||
| if os == "windows" and binary_os == "windows" and native.bazel_version: | ||
| version = native.bazel_version.split(".") | ||
| if int(version[0]) > 7 or (int(version[0]) == 7 and int(version[1]) >= 1): |
There was a problem hiding this comment.
Note: the versions.bzl utility in Bazel-skylib might be appropriate here (if the ruleset already depends on it)
mark-thm
pushed a commit
that referenced
this pull request
Jul 8, 2024
) Relax the Bazel version check for Windows artifacts. Instead of failing when any os accesses a multitool containing Windows binaries on Bazel < 7.1, only fail when loading on Windows. Fixes #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the windows version check. Instead of failing when any os accesses a multitool containing windows binaries at bazel < 7.1, only fail when windows does this access.
Fixes #49