Skip to content

Conversation

@acookin
Copy link
Member

@acookin acookin commented Nov 23, 2025

Trust center preview resolver.

This resolver will delete the previous preview environment (if applicable) before creating the new one

@acookin acookin force-pushed the acookin/trust-center-preview-replace-resolver branch from 6afe769 to f0d2d0d Compare November 23, 2025 21:06
@acookin acookin force-pushed the acookin/trust-center-preview-replace-resolver branch from f0d2d0d to f92c7a9 Compare November 30, 2025 20:12
@acookin acookin changed the base branch from acookin/trust-center-preview-delete-hook to acookin/trust-center-preview-delete-hook-2 November 30, 2025 20:12
@theopenlane-bender
Copy link

🔧 Configuration Changes Detected

This PR contains changes that will affect the Helm chart configuration. A draft infrastructure PR has been automatically created to preview these changes:

📋 Draft PR: theopenlane/openlane-infra#511

Changes Preview:

✅ Updated ConfigMap template

- 🔄 Merged Helm values.yaml
- 🔐 External secrets configuration updated
- ✅ Updated ConfigMap template

The infrastructure PR will automatically convert from draft to ready for review once this core PR is merged.

Base automatically changed from acookin/trust-center-preview-delete-hook-2 to main November 30, 2025 20:48
@acookin acookin force-pushed the acookin/trust-center-preview-replace-resolver branch from f92c7a9 to c8d7e37 Compare December 6, 2025 18:08
@acookin acookin force-pushed the acookin/trust-center-preview-replace-resolver branch from c8d7e37 to 2f8dc49 Compare December 6, 2025 18:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@acookin acookin marked this pull request as ready for review December 6, 2025 18:37
@acookin acookin requested a review from a team as a code owner December 6, 2025 18:37
command.AddCommand(createPreviewSettingsCmd)

// command line flags for the create preview settings command
createPreviewSettingsCmd.Flags().StringP("trust-center-id", "c", "", "trust center id to create preview settings for (required)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be required if an org only has one trust center and the resolver is setting it if not set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants