[DERCBOT-1746] Langfuse V3 Callback Fixes #1954
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benvii
requested changes
Dec 5, 2025
Member
Benvii
left a comment
Benvii
left a comment
There was a problem hiding this comment.
Thanks small issue in get_observability_info.
| list(kwargs.keys()), | ||
| ) | ||
|
|
||
| return LangfuseCallbackHandler( |
Member
There was a problem hiding this comment.
Suggested change
| return LangfuseCallbackHandler( | |
| # Langfuse SDK maintains an internal map / pool of clients based on there public key, that why the client isn't passed to the callbackhandler constructor. | |
| return LangfuseCallbackHandler( |
| if trace_id is None: | ||
| return None | ||
|
|
||
| langfuse_client = get_client() |
Member
There was a problem hiding this comment.
Are you sure you are getting the right client here ?
You should be using the client public key to be sure at least.
You can access the client using observability_handler.client I think it's the easiest way.
This could lead to rights access errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket : DERCBOT-1746
Details
langfuse.callbackAPI to the newlangfuse.langchainmodule.LangfuseCallbackHandlerFactoryto align with the new Langfuse V3 client.get_client()API and revised trace extraction logic.