fixes #178 and #179: rework SSE processing #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SE processing * scope SSE state * allow hoisting SSE processing out of render * add retry behavior * make it so SSE only gets auto-disabled when the server sends a 4XX error * start moving network settings to TockContext
Fabilin
force-pushed
the
178-sse-refactor
branch
from
d67949a to
5bd42f9
Compare
kbvi
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #178 by swapping out the
EventSourceimplementation with Microsoft'sfetch-event-sourcepackage. The new implementation keeps retrying every second except if the server answers with a 4XX HTTP status code.The PR also resolves #179 by scoping the SSE connection to the
useTockhook. To allow preserving the connection across re-mounting of theChatcomponent, it also refactorsuseTockto allow storing all the network context inTockContext.Important
This PR continues a deprecation process started in #164, moving several properties from the
Chatcomponent's properties to theTockSettingsconfiguration object. Direct support of these properties inChatcan be removed in a future major release.