Pass protocol version through from SerialGateway to Gateway. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SerialGateway constructor was missing the protocol_version parameter.
theolind
added a commit
that referenced
this pull request
Oct 5, 2015
Pass protocol version through from SerialGateway to Gateway.
|
@andythigpen have merged now, sorry about not keeping an eye on this repo for the last month! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SerialGateway constructor was missing the protocol_version parameter.
If this is accepted, then I'll send a pull request to HA for this commit to add support for these changes there.