Version 0.4 #14
Merged
Version 0.4 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add protocol_version attribute for Sensor class.
* Fix assigning payload as protocol_version at presentation.
* Change Message attributes type and subtype to integers at init. All
Message attributes should be integers except the payload.
* Fix some minor PEP8 issues.
* Undo removal of int(...) in encode function in Message class.
Still need the conversion for the IntEnum classes.
* Add unit test for Sensor attribute protocol_version.
* Add unit test for encoding of new unchanged Message.
* Fix spelling of persistance -> persistence.
* Add json files to .gitignore.
* Fix some minor PEP8 issues in test.py.
This feature will add support for mysensors switches.
* Add queue as attribute to Gateway class
* Add fill_queue function in Gateway class for putting functions in the
queue.
* Add handle_queue function in Gateway class for getting functions from
the queue, and calling them.
* Add set_child_value function in Gateway class as a convenience
function. It will set a new value for a child and send the
corresponding Message from the gateway to the child's node.
This is not directly but by putting a function with arguments to
the FIFO queue. The function in the queue is the set_child_value
function in the Sensor class.
* Change set_child_value function in Sensor class to return a set
Message.
* Change the loop in the run function in SerialGateway class to handle
queue first, then read from serial interface. If valid input is
read from serial and decoded, add logic function with input as
argument to the queue.
* Add some debug logging to SerialGateway class.
* Fix some minor PEP8 issues.
* Fix problem of reading garbage after disconnecting and reconnecting,
by changing pyserial required version to 2.5 or less.
* Make serial connecting and disconnecting more robust, by sleeping for
a while after connecting, and by checking if connection is open
after connecting, and by closing connection when thread stops.
* Add more logging to serial connection functions.
* Change lowest logging level for log messages to INFO.
* Add function to set log level to debug if debug attribute of gateway
is true.
* Fix logging calls to use proper parameters instead of string
formatting.
* Add function docstrings to fill_queue, handle_queue and
set_child_value functions in Gateway class.
Fix attributes
Conflicts: mysensors/mysensors.py * Solved a couple of minor indentation style conflicts and merged a comment.
Fifo queue, implementing switches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'd like to use the new switch feature in a pull request to home assistant, and then the version needs bumping. I've set the base to master this time, to have the new version on master also.
Best regards,
Martin