Add validation of message and child values #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add valid types in const. * Add message validation called in logic and set_child_value methods. * Add child method validate for child value types and child values. * This method is not used internally, but for use by user of API. * Add protocol_version attribute to ChildSensor class. * Handle persistence and fix pickle persistence. * Allow custom forecast values. * Add tests.
|
Need to check and update persistence tests. |
* Put protocol_version as an argument to the child validate method instead of as an attribute of the child. * Update tests.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POTENTIALLY BREAKING CHANGE: Users that are not adhering to the mysensors serial api could face dropped messages after this change. Messages must follow the mysensors api implemented as in pymysensors after this change.