Skip to content

Improvements #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 7, 2015
Merged

Improvements #1

merged 18 commits into from
Apr 7, 2015

Conversation

andythigpen
Copy link
Collaborator

I apologize in advance for the number of commits in this pull request. I probably should have broken this up into many smaller ones instead...

The major changes include:

  • Refactor to remove (most) pylint/flake8 warnings.
  • Switch to using enums instead of arrays of strings in const.py.
  • Simplify the logic in some areas.
  • Break the unit tests into smaller individual tests.
  • Add support for reconnecting to the serial port during operation -- for instance, if you unplug it and then plug it back in.
  • Add support for multiple values for a child sensor.
  • Move all the code into its own module -- this might make it easier to package for pypi in the future.

I'll send you a separate pull request for the HA component changes so you can review/test those out before we try merge them into the main repo.

andythigpen added 18 commits April 3, 2015 22:41
@andythigpen
Refactor unit tests.
df6a062 
Breaks single unit tests into self smaller tests.
@andythigpen
Refactor logic function into separate functions.
9fbf1f9 
Each message type is processed in a separate function.
@andythigpen
Formatting and cleanup.
aeb6820 
Reformats comments into docstrings and refactors the implementation of a
few minor classes/functions.
@andythigpen
Use IntEnum in const instead of strings.
5c5ac90 
Message stores values as int which can be easily compared with IntEnums
instead of strings.
@andythigpen
Add Message copy function to simplify responses.
308acd5 
Responses typically share most of the same fields, but with the payload
and sub_types sometimes changed.  The copy function will return a new
message with the same fields, optionally overridden by keyword arguments
to the function.
@andythigpen
Refactor addSensor and isSensor functions.
c20779f
@andythigpen
Use logging instead of print.
034f1f0
@andythigpen
Use docstrings in SerialGateway.
46ea602
@andythigpen
Resolve pylint warnings/messages.
ee89111
@andythigpen
Add timeout for serial port.
3d387fc
@andythigpen
Detect disconnects and try to reconnect.
6d974e1
@andythigpen
Move code into module package.
d1ededa
@andythigpen
Continue on timeout.
a24ac98
@andythigpen
Allow multiple sensor values per child.
52341a9
@andythigpen
Resolve flake8 messages.
0019a66
@andythigpen
Update README, main.py to reflect recent changes.
8609716
@andythigpen
Add missing exception messages.
b3937f3
@andythigpen
Fix unit test errors.
75e0f50
@theolind
Copy link
Owner

theolind commented Apr 7, 2015

Awesome. I have looked through the code and tested it. Great updates! Don't worry about the number of commits :). Will merge now. Many thanks!

@theolind theolind merged commit 75e0f50 into theolind:master Apr 7, 2015
@andythigpen andythigpen deleted the improvements branch May 15, 2015 00:40
exxamalte pushed a commit to exxamalte/pymysensors that referenced this pull request Feb 10, 2017
@afeno
Merge pull request theolind#1 from gtortone/dev
760c362 
check socket status before shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andythigpen @theolind