Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpine:3.17 nodejs version breaking builds #157

Closed
leojonathanoh opened this issue Apr 13, 2024 · 0 comments · Fixed by #160
Closed

alpine:3.17 nodejs version breaking builds #157

leojonathanoh opened this issue Apr 13, 2024 · 0 comments · Fixed by #160
Assignees
Labels
bug Something isn't working
Milestone

Comments

@leojonathanoh
Copy link
Member

leojonathanoh commented Apr 13, 2024

Bug

alpine:3.17 nodejs version breaking builds

Expectation

alpine:3.17 nodejs version not breaking builds

Discussion

Successful build 2 weeks ago:

#12 3.831 (27/29) Installing nodejs (18.19.1-r0)
#12 4.038 (28/29) Purging nodejs-current (19.7.0-r0)

Failed build today, installing kerberos fails, after alpine:3.17 updated its nodejs package:

#12 3.935 (27/29) Installing nodejs (18.20.1-r0)
#12 4.154 (28/29) Purging nodejs-current (19.7.0-r0)

# Installing code-server
#12 25.01 npm ERR! npm ERR! In file included from ../node_modules/node-addon-api/napi.h:3189,
#12 25.01 npm ERR! npm ERR!                  from ../src/kerberos.h:11,
#12 25.01 npm ERR! npm ERR!                  from ../src/kerberos.cc:1:
#12 25.01 npm ERR! npm ERR! ../node_modules/node-addon-api/napi-inl.h: In instantiation of 'Napi::ObjectWrap<T>::ObjectWrap(const Napi::CallbackInfo&) [with T = node_kerberos::KerberosClient]':
#12 25.01 npm ERR! npm ERR! ../src/kerberos.cc:64:22:   required from here
#12 25.01 npm ERR! npm ERR! ../node_modules/node-addon-api/napi-inl.h:4414:21: error: invalid conversion from 'void (*)(napi_env, void*, void*)' {aka 'void (*)(napi_env__*, void*, void*)'} to 'node_api_nogc_finalize' {aka 'void (*)(const napi_env__*, void*, void*)'} [-fpermissive]
#12 25.01 npm ERR! npm ERR!  4414 |   status = napi_wrap(env, wrapper, instance, FinalizeCallback, nullptr, &ref);
#12 25.01 npm ERR! npm ERR!       |            ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#12 25.01 npm ERR! npm ERR!       |                     |
#12 25.01 npm ERR! npm ERR!       |                     void (*)(napi_env, void*, void*) {aka void (*)(napi_env__*, void*, void*)}
#12 25.01 npm ERR! npm ERR! In file included from /root/.cache/node-gyp/18.20.1/include/node/node_api.h:12,
#12 25.01 npm ERR! npm ERR!                  from ../node_modules/node-addon-api/napi.h:13:
#12 25.01 npm ERR! npm ERR! /root/.cache/node-gyp/18.20.1/include/node/js_native_api.h:317:69: note:   initializing argument 4 of 'napi_status napi_wrap(napi_env, napi_value, void*, node_api_nogc_finalize, void*, napi_ref__**)'
#12 25.01 npm ERR! npm ERR!   317 |                                              node_api_nogc_finalize finalize_cb,
#12 25.01 npm ERR! npm ERR!       |                                              ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

npm install kerberos reproduces the error.

See nodejs/node#52229, where node 20.12 and 18.20 are affected by this breaking change.

@leojonathanoh leojonathanoh added the bug Something isn't working label Apr 13, 2024
@leojonathanoh leojonathanoh self-assigned this Apr 13, 2024
@leojonathanoh leojonathanoh added this to the next-release milestone Apr 13, 2024
leojonathanoh added a commit to leojonathanoh/docker-code-server that referenced this issue Apr 21, 2024
leojonathanoh added a commit to leojonathanoh/docker-code-server that referenced this issue Apr 21, 2024
leojonathanoh added a commit to leojonathanoh/docker-code-server that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant