Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract skipping or not a finder on Windows into a decorator finder #77

Merged
merged 2 commits into from
Dec 10, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix e2e tests
  • Loading branch information
theofidry committed Dec 10, 2022
commit de8918d1f5fcfbc4ebd713562f58972833f35bd7
6 changes: 4 additions & 2 deletions e2e/expected-output-osx
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ NProcessorFinder: .
NProcFinder(all=true): F
NProcFinder(all=false): F
NullCpuCoreFinder: F
WindowsWmicPhysicalFinder: F
WindowsWmicLogicalFinder: F
OnlyOnWindowsFinder(DummyCpuCoreFinder(value=1)): F
SkipOnWindowsFinder(DummyCpuCoreFinder(value=1)): .
WmicPhysicalFinder: F
WmicLogicalFinder: F
6 changes: 4 additions & 2 deletions e2e/expected-output-ubuntu
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ NProcessorFinder: F
NProcFinder(all=true): .
NProcFinder(all=false): .
NullCpuCoreFinder: F
WindowsWmicPhysicalFinder: F
WindowsWmicLogicalFinder: F
OnlyOnWindowsFinder(DummyCpuCoreFinder(value=1)): F
SkipOnWindowsFinder(DummyCpuCoreFinder(value=1)): .
WmicPhysicalFinder: F
WmicLogicalFinder: F
6 changes: 4 additions & 2 deletions e2e/expected-output-windows
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ NProcessorFinder: F
NProcFinder(all=true): F
NProcFinder(all=false): F
NullCpuCoreFinder: F
WindowsWmicPhysicalFinder: F
WindowsWmicLogicalFinder: F
OnlyOnWindowsFinder(DummyCpuCoreFinder(value=1)): .
SkipOnWindowsFinder(DummyCpuCoreFinder(value=1)): F
WmicPhysicalFinder: F
WmicLogicalFinder: F