feat(frontend): collapsible rule options, preset pills, selection & label updates#36
Merged
theodubus merged 2 commits intoFeb 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
exact/regex) with a single, clearer label and localize selection labels.Description
> Optionsblock under the search bar and applied the same pattern to the edit modal by wrappingRuleOptionsRowin a<details>/<summary>(changes inRulesSection.tsxandEditRuleModal.tsx).PresetPillso presets behave like the other pill controls (changes inPresetsSection.tsxand styling).Requête/Requestand selections show asSélection/Selectionby updatingkindLabeland locale files (fr.json/en.json).PdfViewerthat computes scaledUiRect[]for the selection, passes selection info up toApp, and supports adding aselectionrule; addedUiRect/selectionrule type and included rects in the API payload by addingRectInputandrectssupport toapi.tsandtypes/uiRules.ts.HeaderBar) with the selected file name and drag-and-drop / hidden file input behavior inApp.tsx; also removed the duplicated hint fallback from the right panel by simplifyingResultPanelto not show the standalone hint.PdfViewer: preview highlight drawing refactor, preset-match highlighting (basic), preserving page scale when computing selection rects, and improved rule list/action button styling (RulesList.tsx,PdfViewer.tsx,styles.css).Testing
cd frontend && npm run build, and the production build completed successfully. ✅cd frontend && npm run dev -- --host 0.0.0.0 --port 4173, Vite reported ready. ✅Codex Task