Skip to content

Commit

Permalink
[examples] dependencies with native code should be explicitly listed …
Browse files Browse the repository at this point in the history
…in package.json for native to work properly (onejs#153)

Since `one` is depending on `@react-navigation/native` and `@react-navigation/native` is depending on `react-native-screens` and `react-native-safe-area-context` which have native dependencies. See: https://reactnavigation.org/docs/7.x/getting-started#installing-dependencies-into-a-bare-react-native-project.
  • Loading branch information
zetavg authored Oct 10, 2024
1 parent 379c038 commit f4a0c22
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions examples/one-basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
"one": "1.1.300",
"react": "^18.3.1",
"react-native": "0.74.1",
"react-native-safe-area-context": "^4.10.1",
"react-native-screens": "3.31.1",
"react-native-web": "^0.19.12"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions examples/one-tamagui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"react": "^18.3.1",
"react-native": "0.74.1",
"react-native-reanimated": "~3.10.1",
"react-native-safe-area-context": "^4.10.1",
"react-native-screens": "3.31.1",
"react-native-svg": "15.2.0",
"react-native-web": "^0.19.12",
Expand Down
3 changes: 3 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12360,6 +12360,8 @@ __metadata:
one: "npm:1.1.300"
react: "npm:^18.3.1"
react-native: "npm:0.74.1"
react-native-safe-area-context: "npm:^4.10.1"
react-native-screens: "npm:3.31.1"
react-native-web: "npm:^0.19.12"
vite: "npm:6.0.0-beta.1"
languageName: unknown
Expand Down Expand Up @@ -12444,6 +12446,7 @@ __metadata:
react: "npm:^18.3.1"
react-native: "npm:0.74.1"
react-native-reanimated: "npm:~3.10.1"
react-native-safe-area-context: "npm:^4.10.1"
react-native-screens: "npm:3.31.1"
react-native-svg: "npm:15.2.0"
react-native-web: "npm:^0.19.12"
Expand Down

0 comments on commit f4a0c22

Please sign in to comment.