feat: 83 replace poetry co by uv and ruff #91
Conversation
…led if not there by default
|
@atstaeff Das |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the build and dependency management tooling from Poetry to uv while also standardizing code formatting (e.g. using double quotes) and updating configuration files. Key changes include updating import and quoting styles in many modules, refactoring the build and CI scripts, and adjustments to type annotations and error messages.
Reviewed Changes
Copilot reviewed 54 out of 57 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/* | Minor style updates (quote changes, formatting improvements) |
| eventsourcingdb/* | Standardized string literals and updated error messages; refactored import order |
| Configuration files (pyproject.toml, Makefile) | Updated dependency definitions and CI workflows to support uv, ruff, and bandit |
Comments suppressed due to low confidence (1)
eventsourcingdb/read_events/read_events_options.py:24
- Consider using the Bound object's to_json() method or explicitly converting 'type' to its enum value (e.g. self.lower_bound.type.value) for both lower_bound and upper_bound to ensure consistent JSON serialization.
json["lowerBound"] = {"id": str(self.lower_bound.id), "type": self.lower_bound.type}
| uv sync | ||
| uv sync --dev |
There was a problem hiding this comment.
uv sync --dev genügt hier, da es nicht nur die Dev-Dependencies installiert, sondern auch die eigentlichen Dependencies.
| uv sync | ||
| uv sync --dev |
| # IDE | ||
| .idea/ | ||
| .vscode/ | ||
| .ipynb_checkpoints/ |
There was a problem hiding this comment.
Das gehört hier IMHO nicht rein – das sollte in der globalen .gitignore jeder Entwicklerin und jedes Entwicklers liegen (ansonsten sammelt sich hier im Lauf der Zeit nämlich eine Unmenge an Zeugs an, für IDEs, die keiner mehr benutzt).
|
|
||
| .PHONY: analyze build clean format lock qa test | ||
| .PHONY: analyze build coverage format help lock qa security test typecheck clean |
There was a problem hiding this comment.
Da das jetzt hier ja ein bisschen länger wird, sollten wir das umbrechen (siehe zB hier: https://github.com/thenativeweb/eventsourcingdb-client-dotnet/blob/main/Makefile#L35-L40).
There was a problem hiding this comment.
Die sollte nicht gelöscht werden.
| "PTH123", # open() should be replaced by Path.open() | ||
|
|
||
| # Async | ||
| "ASYNC251", # Async functions should not call time.sleep |
There was a problem hiding this comment.
Was spricht gegen die empfohlene Lösung, asyncio.sleep zu verwenden?
| "PERF401", # Use an async list comprehension to create a transformed list | ||
|
|
||
| # Style | ||
| "COM812", # Trailing comma missing |
There was a problem hiding this comment.
Wenn das empfohlen wird mit dem Trailing-Komma im Default, sollten wir das – denke ich – so machen.
| "C901", # Function is too complex | ||
|
|
||
| # Performance | ||
| "PERF401", # Use an async list comprehension to create a transformed list |
There was a problem hiding this comment.
Was spricht gegen List-Comprehensions?
| "PLR0912", # Too many branches | ||
| "PLR0913", # Too many instance attributes | ||
| "PLR0917", # Too many arguments | ||
| "SIM102", # Use a single if statement instead of nested if statements |
There was a problem hiding this comment.
Das würde ich nicht global ausschalten, sondern wenn, dann nur lokal.
|
|
||
| # Import related | ||
| "F401", # Imported but unused | ||
| "TID252", # Prefer absolute imports over relative imports from parent modules |
There was a problem hiding this comment.
Was spricht dagegen, mit absoluten Importen zu arbeiten?
No description provided.