fix: add multiple prop to dropzone #1487
Conversation
|
@okosohor is attempting to deploy a commit to the Themesberg Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes introduce a new optional property Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/lib/forms/Dropzone.svelte (1)
Line range hint
1-48: Consider enhancing the drag and drop experienceWhile the multiple file support is implemented correctly, the user experience could be improved.
Consider these enhancements:
- Update the drag-and-drop visual feedback to indicate multiple file support
- Add a prop to limit the number of files that can be selected
- Add validation for allowed file types when multiple files are selected
Would you like me to provide implementation suggestions for any of these improvements?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
src/lib/forms/Dropzone.svelte(3 hunks)
🔇 Additional comments (4)
src/lib/forms/Dropzone.svelte (4)
9-9: LGTM! Clean interface extension
The multiple property is correctly added as an optional boolean to the DropzoneProps interface.
17-17: LGTM! Property export follows conventions
The multiple property export is well-typed and has a sensible default value of false.
38-38: Verify accessibility for multiple file selection
The input binding looks correct, but we should ensure proper accessibility for multiple file selection scenarios.
Consider adding an ARIA label that indicates multiple file selection is possible when multiple is true:
- <input {...$$restProps} {multiple} bind:value bind:files bind:this={input} on:change on:click type="file" />
+ <input
+ {...$$restProps}
+ {multiple}
+ bind:value
+ bind:files
+ bind:this={input}
+ aria-label={multiple ? "Choose files" : "Choose a file"}
+ on:change
+ on:click
+ type="file"
+ />48-48: LGTM! Documentation is up to date
The new property is properly documented following the existing format.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Since the component is extended HTMLInputAttributes, and |
Closes #
📑 Description
Add multiple prop to Dropzone, because now we have possibility to load many files only with drag & drop
Status
✅ Checks
ℹ Additional Information
Summary by CodeRabbit