Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(src/components/navbar): change default <Navbar.Toggle/> icon #819

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

tulup-conner
Copy link
Collaborator

@tulup-conner tulup-conner commented Jun 22, 2023

Description

Fixes #818

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Breaking changes

None

How Has This Been Tested?

  • Visual inspection of yarn dev
  • Visual inspection of Vercel deployment

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@tulup-conner tulup-conner added this to the 1.0.0 milestone Jun 22, 2023
@tulup-conner tulup-conner self-assigned this Jun 22, 2023
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 8:44am

@tulup-conner tulup-conner marked this pull request as ready for review June 22, 2023 08:44
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rluders rluders merged commit 6bc0de9 into main Jun 22, 2023
@rluders rluders deleted the fix/upgrade-react-icons branch October 3, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error during building project as 'GoThreeBars' is not exported from 'react-icons/go'
2 participants