-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated theme mode 'auto' to remove storage integration #1400
base: main
Are you sure you want to change the base?
Updated theme mode 'auto' to remove storage integration #1400
Conversation
…tabs firing into too often.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes introduce a debounce mechanism to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/ui/src/hooks/use-theme-mode.ts (4 hunks)
Additional comments not posted (4)
packages/ui/src/hooks/use-theme-mode.ts (4)
3-3
: The import and application ofdebounce
tohandleSetMode
are correctly implemented.Also applies to: 50-50
44-44
: RenaminghandleSetMode
to_handleSetMode
and its implementation are correctly handled.
136-136
: The implementation ofprefersColorScheme
to determine the browser's preferred color scheme is correct.
Line range hint
3-136
: The overall structure and consistency of the file are maintained well.
*/ | ||
const setModeInLS = (mode: ThemeMode) => localStorage.setItem(LS_THEME_MODE, mode); | ||
const setModeInLS = (mode: ThemeMode) => { | ||
if (mode === "auto") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will break the current logic, auto
value is meant to be saved in LS and from that computed to either light
or dark
Summarize the changes made and the motivation behind them.
Reference related issues using
#
followed by the issue number.#1352