-
-
Notifications
You must be signed in to change notification settings - Fork 476
packages(ui): build step using rollup + tsc #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r dts files [WIP]
…l plugin using `rimraf`
🦋 Changeset detectedLatest commit: 50c7cdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate Limit Exceeded@SutuSebastian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 7 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe overarching change focuses on enhancing the build process and integration of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chore: apps(web) - update `tailwind.config` to use `.mjs`
…the `content` and `plugins` values for `tailwind.config.js` - change build output folder from `lib` to `dist` - chore: apps(web): use new plugi in `tailwind.config`
…wind` file which exports getters for `content` and `plugin` chore: apps(web): use new `flowbite-react/tailwind` in `tailwind.config`
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* refactor: packages(ui) - use `rollup` to build and transpile + tsc for dts files [WIP] * chore: packages(ui) - remove `rollup-plugin-delete` replace with local plugin using `rimraf` * fix: packages(ui) - build step generateDts overriding the rest * fix: packages(ui) - rework tsconfig files chore: apps(web) - update `tailwind.config` to use `.mjs` * feat: packages(ui) - create tailwind plugin for easier management of the `content` and `plugins` values for `tailwind.config.js` - change build output folder from `lib` to `dist` - chore: apps(web): use new plugi in `tailwind.config` * feat: packages(ui) - remove tailwind plugin and replace it with `tailwind` file which exports getters for `content` and `plugin` chore: apps(web): use new `flowbite-react/tailwind` in `tailwind.config` * chore: remove comments * chore: remove unused package * chore: remove rollup external leftover path * chore: add `trustedDependencies` for `postinstall` script to work in CI env * chore: get rid of `postinstall` lifecycle script and configure turborepo to handle the sequence of `apps/web` build and dev scripts * fix: turborepo `packages/ui` script dependencies * chore: rollup config - remove redundant array structure * chore: simplify turbo configs + fix `packages/ui` outputs path * chore: update docs introduction and installation guides to new config * fix: docs redwood guide tailwind config path * chore: remove comment * fix: docs redwood guide tailwind config path typo * chore: add changeset * Update .changeset/hungry-toys-care.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update .changeset/hungry-toys-care.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update .changeset/hungry-toys-care.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update .changeset/hungry-toys-care.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: bump version minor --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary
In order to bring more performance to the build process of
flowbite-reactpackage, we have to consider transpiling the files using other tools rather thantsc, which is very slow.After evaluating various tools including
tsup,tshy, andbun build, we choserollupwith theesbuildplugin for transpiling due to its performance and flexibility. We continue to usetscsolely for generating*.d.tsdeclaration files.Changes
rollup+esbuildfor transpiling filescjsdirectory now have.cjsextensionesmdirectory now have.mjsextension*.d.ts) have been moved fromdist/esmtodist/typeslibtodistcontentpath as well as thepluginapps/webto properly pipe and require the build output ofpackages/uiin certain script steps such asbuildanddevintroductionandintegration guidespages to use the new utility for tailwindcontentandpluginsBreaking changes
tailwind.config.jscontentpath:old:
"node_modules/flowbite-react/lib/esm/**/*.js"new:
"node_modules/flowbite-react/dist/esm/**/*.mjs"- (flowbite.content()returns it)Before
After
Issues
#1326, #1329, #1343
Summary by CodeRabbit
New Features
flowbite-reactfor improved performance.Documentation
Refactor
packages/uito enhance build efficiency..gitignoreconfigurations to align with new directory structures.Chores
turbo.jsonandpackage.jsonconfigurations for optimized build and development processes.