fix(button & dropdownitem): reverts return type of Button & DropdownItem to JSX.Element #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
…n the button `as` prop (themesberg#1244)" This reverts commit a6698d4.
rnicholus
force-pushed
the
fix/button-and-dropdown-typescript-regression
branch
from
12a345c to
f6fa786
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
==========================================
- Coverage 99.54% 95.51% -4.03%
==========================================
Files 163 218 +55
Lines 6621 9641 +3020
Branches 401 554 +153
==========================================
+ Hits 6591 9209 +2618
- Misses 30 432 +402 ☔ View full report in Codecov by Sentry. |
|
it seems there are a number of changes built on top of the issues introduced in #1244. fixing this is going to be non-trivial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1244, the return type of Button and DropdownItem was changed to ReactNode. This is not an acceptable return type for functional components. The correct return type is JSX.Element. This change fixes the regression from that PR (introduced in v0.7.3. Also fixes #962.