Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/timeline vertical #1224

Closed
wants to merge 2 commits into from
Closed

Conversation

revuwem
Copy link

@revuwem revuwem commented Jan 9, 2024

Fixed the problem with vertical-oriented <Timeline.Content /> component style. The root.base class theme prop is now independent on orientation. The optional root.vertical and root.horizontal props were introduced to make orientation-specific style changes.

Fix #1196

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

interface FlowbiteTimelineContentTheme has been changed. The theme now supports optional root.vertical and root.horizontal props.

make root.base independent from component orientation, introduce orientation-specific classes

fix themesberg#1196
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 0:11am

Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, just those 2 comments needs fixing

Copy link

vercel bot commented Mar 19, 2024

Deployment failed with the following error:

Creating the Deployment Timed Out.

@SutuSebastian
Copy link
Collaborator

ported to #1430 due to new monorepo structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimelineContent is not taking theme styles when being in vertical mode
2 participants