-
Notifications
You must be signed in to change notification settings - Fork 49
Refactor components properties #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: `iconOnly` is now `isIconOnly` and must be `enabled` or `disabled`
BREAKING CHANGES: `boolean` variables are now FlowbiteBoolean usable with `ènabled` or `disabled`
BREAKING CHANGES: `boolean` variables are now FlowbiteBoolean usable with `ènabled` or `disabled`
BREAKING CHANGES: `boolean` variables are now FlowbiteBoolean usable with `ènabled` or `disabled` /!\ Flowbite data attribute api don't work
BREAKING CHANGES: `boolean` variables are now FlowbiteBoolean usable with `ènabled` or `disabled` `outline` is now either `outline` or `solid`
BREAKING CHANGES: `boolean` variables are now FlowbiteBoolean usable with `ènabled` or `disabled`
switch from flowbiteBoolean to boolean when return and setting component's data data is still stored as FlowbiteBoolean
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
But so nice u fixed that animation flicker on reload 🔥 |
9544448 to
095e43d
Compare
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces significant updates across various components in the Flowbite Angular library, primarily focusing on enhancing the HTML structure and theming capabilities. Key modifications include replacing property bindings with direct attribute assignments, introducing dynamic class bindings using Angular's Changes
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
apps/docs/src/app/pages/alert-page/alert-page.component.tsOops! Something went wrong! :( ESLint: 8.56.0 TypeError: Error while loading rule '@nx/enforce-module-boundaries': Cannot read properties of undefined (reading 'keyword') Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* refactor(component/badge): refactor styling code * feat(component/badge): add customizable theme * refactor(theme): move theme to comon theme file * refactor(component/indicator): refactor styling code * refactor(component/indicator): use conditional classes from twMerge * refactor(component/navbar): refactor styling code * refactor(component/alert): refactor styling code * refactor(component/alert): remove flowbite data attribute * refactor(component/button): refactor styling code * refactor(component/accordion): refactor styling code * refactor(component/breadcrumb): refactor styling code * refactor(component/dropdown): refactor styling code * refactor(component/sidebar): refactor styling code * refactor(component/dropdown): refactor styling code * refactor(component/modal): refactor styling code * refactor(component/forms): refactor styling code * refactor(component): update theme name file * refactor(component): update theme return type * feat(component): add dynamic update style * docs(component): add comment to components and Input * feat(component): flowbiteBoolean to boolean * feat(component): add customizable properties value * refactor(doc): remove [] in template --------- Co-authored-by: GREMY Miguel <miguel.gremy@sully-group.fr>


Summary by CodeRabbit
Release Notes
New Features
Refactor
BaseComponent, standardizing functionality.Bug Fixes
Documentation